Repository navigation
Conversation
Contributor
[Medium impact] The PR appears safe to merge. Summary
Reviews (1) · Last reviewed commit: "fix: keep every enum value when a dedupl..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When two enum values sanitize to the same Go name, SanitizeEnumNames appends a numeric suffix. That suffix could land on a name another value already owns, and the map write silently replaced it. For example
enum: [A, a, A1]produced onlyAandA1, so one value lost its constant (and[A, A1, a]lostA1's original mapping the same way).The suffix loop now skips any name that another value claims or that is already taken, so the example yields
A,A2andA1. Enums without such a collision keep exactly the names they had before. The new test covers collisions with a later and an earlier value, plus the unchanged no-collision case.