Repository navigation
docs: generated code requires Go 1.26 - #2668
Merged
Merged
Conversation
Generated code imports github.com/oapi-codegen/runtime, and with the JSON codec change (oapi-codegen#2665) it needs runtime v1.9.0, which requires Go 1.26. The README still listed Go 1.24 or 1.25 per server and said the generated code has lower requirements than oapi-codegen itself. Set every row of the Supported Servers table to 1.26+, and reword the table's introduction and the note under Installing to say that the generated code has the same Go 1.26 floor and why. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
 [Low impact] This documentation-only change appears safe to merge. SummaryUpdates
Reviews (1) · Last reviewed commit: "docs: generated code requires Go 1.26" · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated code imports github.com/oapi-codegen/runtime, and with the JSON codec change (#2665) it needs runtime v1.9.0, which requires Go 1.26. The README still listed Go 1.24 or 1.25 per server and said the generated code has lower requirements than oapi-codegen itself.
Set every row of the Supported Servers table to 1.26+, and reword the table's introduction and the note under Installing to say that the generated code has the same Go 1.26 floor and why.