Repository navigation
fix: give inline-enum items of a oneOf/anyOf array branch their own type name - #2653
Open
ahm3dwasim wants to merge 2 commits into
Open
ahm3dwasim wants to merge 2 commits into
ahm3dwasim wants to merge 2 commits into
Conversation
…ype name An array branch of a union is named after its path, and its items' inline enum was named from that same path, so both types got one name: the output failed to compile, or generation failed with a duplicate typename. Name the items' enum after the branch plus "Item" in that position only, leaving every other generated name unchanged. Fixes oapi-codegen#2640
Contributor
 [Low impact] The PR appears safe to merge; both previous findings are fixed. SummaryGives inline enum items their own names when they belong to an array branch of
Reviews (2) · Last reviewed commit: "fix: preserve explicit enum names in uni..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An array branch of a
oneOf/anyOfis named after its path, and the inline enum of its items was named from that same path, so both got one type name. The output either failed to compile or generation stopped with a duplicate typename (#2640).This names the items' enum after the branch plus
Item, in that position only. The marker is cleared as soon as codegen descends into the branch, so nested schemas (for example an array property inside an object branch, or object items of an array branch) keep their current names. No existing generated name changes; no fixtures change.Tests:
TestUnionArrayBranchOfInlineEnum: the issue's componentanyOfand request-bodyoneOfcases now generate distinct types (fails on main withduplicate typename).TestUnionObjectBranchArrayPropertyInlineEnumName: an array property with an inline enum inside an object branch keeps the nameChoice0Roles, same as main.gofmt,go vet ./pkg/codegenand the focused tests pass.Fixes #2640