Repository navigation
Conversation
A oneOf/anyOf branch that $refs a whole file names no Go type, so generateUnionElement must name it after its path like an inline branch, instead of using its inline struct as the accessor name. Fixes oapi-codegen#2639.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2639.
A
oneOf/anyOfbranch that$refs a whole file has a non-emptyRefbut names no Go type (#308), sogenerateUnionElementskipped naming it and the accessors came out asAsStruct {...}(). Checking!IsGoTypeReference(element.Ref)instead names it after its path, like an inline branch. Diagnosis and fix are from @BogdanYarotsky.Added
internal/test/references/external/whole_file_unionwith the four forms from the issue (response body, mixedanyOf, component schema, property). It fails to generate without the fix.make generatedoesn't change any existing generated code, andgo test ./...passes in all three modules.