Skip to content

fix: handle untyped strict JSON responses #2514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Boulea7 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: handle untyped strict JSON responses #2514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4520abb
fix: wrap receiver-incompatible strict JSON responses
Boulea7 Aug 11, 2026
4243417
test: cover strict JSON response receiver compatibility
Boulea7 Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions internal/test/references/multipackage/response_cast/config.other-fiber.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
# yaml-language-server: $schema=../../../../../configuration-schema.json
package: spec_other_fiber
generate:
fiber-server: true
strict-server: true
models: true
import-mapping:
./spec-base.yaml: "github.com/oapi-codegen/oapi-codegen/v2/internal/test/references/multipackage/response_cast/gen/spec_base"
output: gen/spec_other_fiber/issue.gen.go
output-options:
skip-prune: true
12 changes: 12 additions & 0 deletions internal/test/references/multipackage/response_cast/config.other-iris.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
# yaml-language-server: $schema=../../../../../configuration-schema.json
package: spec_other_iris
generate:
iris-server: true
strict-server: true
models: true
import-mapping:
./spec-base.yaml: "github.com/oapi-codegen/oapi-codegen/v2/internal/test/references/multipackage/response_cast/gen/spec_base"
output: gen/spec_other_iris/issue.gen.go
output-options:
skip-prune: true
14 changes: 9 additions & 5 deletions internal/test/references/multipackage/response_cast/doc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
// Regression fixture for https://github.com/oapi-codegen/oapi-codegen/issues/2010.
// Regression fixture for:
// - https://github.com/oapi-codegen/oapi-codegen/issues/1328
// - https://github.com/oapi-codegen/oapi-codegen/issues/2010
//
// The base spec defines components/responses/400 with a JSON body. The "other"
// spec references that response via an external $ref. With strict-server
// enabled in both packages, the embedded response field name must agree across
// packages so cross-package response casts compile.
// The base spec defines reusable responses with concrete, untyped, pointer,
// and header-bearing JSON bodies. The "other" specs reference those responses
// via external $refs. With strict-server enabled in both packages, the imported
// response envelope must remain embedded so cross-package response casts compile.
package responsecast

//go:generate go run github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen --config=config.base.yaml spec-base.yaml
//go:generate go run github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen --config=config.other.yaml spec-other.yaml
//go:generate go run github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen --config=config.other-fiber.yaml spec-other.yaml
//go:generate go run github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen --config=config.other-iris.yaml spec-other.yaml
176 changes: 176 additions & 0 deletions internal/test/references/multipackage/response_cast/gen/spec_base/issue.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading