Use net/http constants in boilerplate#2398
Open
mromaszewicz wants to merge 1 commit into
Open
Conversation
mromaszewicz
force-pushed
the
fix/issue-2397
branch
from
June 5, 2026 22:28
e06f625 to
31d000a
Compare
Contributor
Greptile SummaryThis PR replaces generated raw HTTP status numbers with
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| pkg/codegen/operations.go | Adds the fixed status-code to net/http constant mapping used by generated output. |
| pkg/codegen/template_helpers.go | Updates generated client response conditions to compare against HTTP status constants. |
| pkg/codegen/templates/strict/strict-interface.tmpl | Emits HTTP status constants for fixed strict-server response codes. |
| pkg/codegen/templates/strict/strict-fiber-interface.tmpl | Emits HTTP status constants for fixed Fiber strict-server responses. |
| pkg/codegen/templates/strict/strict-iris-interface.tmpl | Emits HTTP status constants for fixed Iris strict-server responses. |
Reviews (2): Last reviewed commit: "Use net/http constants in boilerplate" | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Closes: oapi-codegen#2397 Replace raw integer literals in generated strict server code with named net/http constants (e.g. http.StatusOK instead of 200). Covers WriteHeader/Status/StatusCode calls in all strict server templates and status code comparisons in generated client switch statements. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
mromaszewicz
force-pushed
the
fix/issue-2397
branch
from
June 5, 2026 22:38
31d000a to
3988907
Compare
Member
Author
|
@greptileai, please look again, comments addressed. |
jamietanna
reviewed
Jun 18, 2026
| return httpStatusConstant(r.StatusCode) | ||
| } | ||
|
|
||
| func httpStatusConstant(code string) string { |
Member
There was a problem hiding this comment.
Might be worth a test to help us catch when new statuses are added to the standard library, if straightforward?
Member
Author
There was a problem hiding this comment.
We'd have to grep the standard library source. I think being lazy here is ok. The fallback to not using the constant will work, and we can address as-needed.
jamietanna
approved these changes
Jun 18, 2026
jamietanna
left a comment
jamietanna
left a comment
Member
There was a problem hiding this comment.
Agreed this doesn't really provide too much additional value, but it can help consistency that a lot of folks' "production code" would do
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #2397
Replace raw integer literals in generated strict server code with named net/http constants (e.g. http.StatusOK instead of 200). Covers WriteHeader/Status/StatusCode calls in all strict server templates and status code comparisons in generated client switch statements.