fix: Change FormParams to FormValues for Echo v5#2311
Conversation
Greptile SummaryThis PR fixes a bug in the Echo v5 strict handler template where
Confidence Score: 4/5This PR is safe to merge; the fix is a minimal, targeted API rename with no logic changes. The change is a straightforward one-line substitution of a deprecated Echo v5 API call. The return type and usage pattern are identical, so downstream code (runtime.BindForm) remains correct. The main gap is the absence of an integration test specifically covering the Echo v5 strict handler with form-data bodies, meaning regressions would not be caught automatically, which keeps the score from being a 5. No files require special attention beyond pkg/codegen/templates/strict/strict-echo5.tmpl.
|
| Filename | Overview |
|---|---|
| pkg/codegen/templates/strict/strict-echo5.tmpl | Replaces the deprecated ctx.FormParams() with ctx.FormValues() for Echo v5 form data handling in the strict handler template. |
Reviews (1): Last reviewed commit: "change FormParams to FormValues" | Re-trigger Greptile
In Echo v5,
ctx.FormParams()seems to have been deprecated in favor ofctx.FormValues(), which has the same signature. The code generation, when echo v5 was specified, was generating code with.FormParams()and not.FormValues(), leading to an error in the generated code.