@greptileai

Greptile Summary

This PR fixes a bug where allOf extending an external schema would leave nested #/... refs (array items, additionalProperties, and sub-object properties) unqualified, producing broken Go type names like *[]Role instead of *[]externalRef0.Role. The fix extracts the existing per-property ref-rewriting into a new recursive propagateRemoteRefs helper and extends it to cover Items and AdditionalProperties, then adds a concrete User/Role/EnrichedUser regression test that exercises the array-items case from the reported issue.

• pkg/codegen/merge_schemas.go: Refactors valueWithPropagatedRef to call a new propagateRemoteRefs function that recursively walks Properties, Items, and AdditionalProperties, rewriting any local #/... ref to include the remote file path.
• internal/test/externalref/packageB/spec.yaml: Adds Role (string enum) and User (object with a roles: []Role array property) to supply the external types for the regression test.
• internal/test/externalref/packageA/spec.yaml: Adds EnrichedUser as an allOf extension of the external User, reproducing issue allOf with cross-file does not qualify nested type references from source schema #2288.
• Gap to be aware of: propagateRemoteRefs does not yet walk AnyOf, OneOf, AllOf, or Not sub-schemas. External types that use those composition keywords internally with local refs could trigger the same class of bug in a follow-up scenario.

Confidence Score: 4/5

• Safe to merge; correctly fixes the reported array-items qualification bug with a targeted regression test.
• The core logic is correct and the fix is well-scoped to the reported issue. The only gap is that AnyOf/OneOf/AllOf/Not sub-schema refs are not yet walked, which could resurface the same class of bug for schemas using those keywords — but that is a follow-up concern, not a regression from this PR.
• pkg/codegen/merge_schemas.go — consider extending propagateRemoteRefs to cover AnyOf/OneOf/AllOf/Not in a follow-up.

_{Reviews (1): Last reviewed commit: "Propagate external refs into allOf" | Re-trigger Greptile}

I tested your patch with the following files, which is an extract of a bigger api in which I encountered the same issue.

cfg-api.yaml:

package: api
output: api.gen.go
generate:
  models: true
output-options:
  # to make sure that all types are generated
  skip-prune: true
import-mapping:
  ./types.yaml: "types"

api.yaml:

components:
  schemas:
    CustomerStatusPostPayloadV1:
      allOf:
        - $ref: './types.yaml#/components/schemas/CustomerStatusV1'
        - type: object
          properties:
            name:
              type: string

types.yaml

components:
  schemas:
    CustomerStatusEnum:
      type: string
      enum:
        - Approved
        - Disputed
        - Suspended

    CustomerStatusV1:
      allOf:
        - type: object
          properties:
            status:
              $ref: '#/components/schemas/CustomerStatusEnum'

The generated files still doesn't reference the enum properly:

// Package api provides primitives to interact with the openapi HTTP API.
//
// Code generated by github.com/oapi-codegen/oapi-codegen/v2 version v2.6.0 DO NOT EDIT.
package api

// CustomerStatusPostPayloadV1 defines model for CustomerStatusPostPayloadV1.
type CustomerStatusPostPayloadV1 struct {
	Name   *string             `json:"name,omitempty"`
	Status *CustomerStatusEnum `json:"status,omitempty"`
}

@cdevienne , thanks for this example. I'm very minimalist with this code because this aggregate schema traversal is so fragile. Could you see if this latest PR works for you? I've reproduced your test case in our unit tests, and it failed before my changes, and passes after.

@mromaszewicz Tested it, it works!

I have another similar issue though, will report it separately.

Thanks a lot

Just in case, the similar issue I got is: #2308