Skip to content

fix: include additional types for array response type #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
viktorasm wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: include additional types for array response type #1930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9dd2130
wip
viktorasm Mar 15, 2025
118a57e
wip
viktorasm Mar 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions internal/test/issues/issue1277/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
package: issue1277
generate:
models: true
chi-server: true
strict-server: true
output: content-array.gen.go
255 changes: 255 additions & 0 deletions internal/test/issues/issue1277/content-array.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions internal/test/issues/issue1277/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
package issue1277

//go:generate go run github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen --config=config.yaml spec.yaml
23 changes: 23 additions & 0 deletions internal/test/issues/issue1277/spec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
openapi: "3.0.1"
info:
title: a
version: 1.0.0
paths:
/test:
get:
operationId: test
responses:
"200":
description: desc
content:
application/json:
schema:
type: array
items:
type: object
properties:
field1:
type: string
fieldX:
type: string
additionalProperties: true
2 changes: 2 additions & 0 deletions internal/test/strict-server/chi/server.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions internal/test/strict-server/echo/server.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions internal/test/strict-server/gin/server.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions internal/test/strict-server/gorilla/server.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions internal/test/strict-server/stdhttp/server.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions pkg/codegen/templates/strict/strict-interface.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@
}
{{end}}

{{- range .Schema.AdditionalTypes}}
type {{.TypeName}} {{if .IsAlias }}={{end}} {{.Schema.TypeDecl}}
{{- end}}

func (response {{$receiverTypeName}}) Visit{{$opid}}Response(w http.ResponseWriter) error {
{{if eq .NameTag "Multipart" -}}
writer := multipart.NewWriter(w)
Expand Down