Skip to content

fix: multiline indented lines in parameter descriptions break overlay functionality#1928

Closed
viktorasm wants to merge 9 commits into
oapi-codegen:mainfrom
viktorasm:fix/load-overlay-issues
Closed

fix: multiline indented lines in parameter descriptions break overlay functionality#1928
viktorasm wants to merge 9 commits into
oapi-codegen:mainfrom
viktorasm:fix/load-overlay-issues

Conversation

@viktorasm

@viktorasm viktorasm commented Mar 15, 2025

Copy link
Copy Markdown
Contributor

Fixes #1927

@viktorasm viktorasm requested a review from a team as a code owner March 15, 2025 09:53
@viktorasm viktorasm changed the title reproduce #1927 fix: multiline indented lines in parameter descriptions break overlay functionality Mar 15, 2025
@mromaszewicz

Copy link
Copy Markdown
Member

Thank you for submitting this PR, @viktorasm — but we need to close it because the same workaround (setting the YAML encoder indent to 2, working around go-yaml#76) was independently merged via #2172 (commit 77bda899). pkg/util/loader.go:53 now contains enc.SetIndent(2) with the comment referencing the upstream issue.

Thanks for the diagnosis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Multiline descriptions with leading spaces may break overlay functionality

2 participants