support all x-* extensions and with ref#1880
Open
paulmach wants to merge 2 commits intooapi-codegen:mainfrom
Open
support all x-* extensions and with ref#1880paulmach wants to merge 2 commits intooapi-codegen:mainfrom
paulmach wants to merge 2 commits intooapi-codegen:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is meant to address #863 which asks for
x-go-typeto work with$ref. It also fixes my use case which is forx-oapi-codegen-extra-tagslike:I have added tests in the
internal/tests/extensionsdirectory to cover a few of the extensions, I can add a complete list if desired.We already treat
x-orderin this way (use the value next to the ref if provided) as of #1700 and this pr makes the functionality complete and consistent for all supported extensions.