build: ensure separately named "Check results" steps#1850
Merged
jamietanna merged 1 commit intomainfrom Nov 28, 2024
Merged
Conversation
This makes sure these are now 4 separate checks, which can be independently added, which ensures that all stages run successfully before an auto-merge applies. Previously, we've had cases where a PR can be automerged before all checks execute, as GitHub sees that one of the `Check results` steps has passed, and expects all of them have.
jamietanna
added
the
chore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure these are now 4 separate checks, which can be
independently added, which ensures that all stages run successfully
before an auto-merge applies.
Previously, we've had cases where a PR can be automerged before all
checks execute, as GitHub sees that one of the
Check resultssteps haspassed, and expects all of them have.