Skip to content

fix(codegen): Recursively propagate external references when merging#1842

Closed
hego-fdc wants to merge 1 commit into
oapi-codegen:mainfrom
hego-fdc:fix-allof-external-references
Closed

fix(codegen): Recursively propagate external references when merging#1842
hego-fdc wants to merge 1 commit into
oapi-codegen:mainfrom
hego-fdc:fix-allof-external-references

Conversation

@hego-fdc

Copy link
Copy Markdown

Fixes #1841

@LarsStegman

Copy link
Copy Markdown

@jamietanna any chance this could get merged? I think it would fix many open issues.

#1841
#2008
#2060
#2088

@mromaszewicz

Copy link
Copy Markdown
Member

Thank you for submitting this PR, @hego-fdc — but we need to close it because the recursive external-ref propagation work landed via #2299 (commit 1c89479b), which extracted a propagateRemoteRefs helper that walks Items, AdditionalProperties, and AllOf/AnyOf/OneOf/Not. A repro of the issue #1841 spec now generates B *[]externalRef0.Element correctly.

Thanks for the contribution — you correctly identified the gap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

External references are not propagated recursively when merging "allOf" fields

3 participants