Closed
Conversation
jamietanna
requested changes
Nov 3, 2024
Member
jamietanna
left a comment
jamietanna
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Unfortunately, this is something that's unlikely to merge right now, as the package reshuffle looks like it may be a breaking change for anyone consuming oapi-codegen as a library (opposed to as a CLI)
jamietanna
requested changes
Nov 3, 2024
Member
jamietanna
left a comment
jamietanna
left a comment
There was a problem hiding this comment.
And although we appreciate that this may improve understanding + being able to contribute, this particular change (with how it may be breaking and to make it non-breaking we need to add extra pieces to manage it similar to #1388) isn't something we'll be prioritising, but thanks for your work on it!
Hopefully this has given you a chance to understand the codebase more 🤞🏽
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I would like to contribute to the codebase, but found it hard to follow with everything in one package. This is my first attempt at a restructure. The starting point for any restructure is the global state var in codegen, not moving it to its own package causes a lot of cyclic dependencies