fix: type hint for discriminator types#1745
Closed
mweibel wants to merge 1 commit into
Closed
Conversation
Author
|
@jamietanna would you be able to review this? and maybe point me in the direction on writing tests for this particular case |
Member
|
I'll try and have a look once I've got the v2.4.0 release backlog out ☺ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1668
❓ I'd need help writing the appropriate test code. I haven't found the best way to make sure this works and continues to works in the future yet and would appreciate some help. I tried adding a check (using parser.ParseFile) in
codegen/codegen_test.goto make sure the generated code is parseable but wasn't yet able to make it work.