Properly merge discriminator when combining schema's using allOf#1738
Closed
alexbakker wants to merge 1 commit into
Closed
Properly merge discriminator when combining schema's using allOf#1738alexbakker wants to merge 1 commit into
alexbakker wants to merge 1 commit into
Conversation
Previously, when combining two schema's using allOf, the discriminator would not carry over to the resulting merged schema.
alexbakker
force-pushed
the
fix-discriminator-allof
branch
from
a2a29c9 to
8507cc4
Compare
Author
|
@jamietanna What's the status here? |
Member
|
Thank you for submitting this PR, @alexbakker — but we need to close it because the same fix (propagating the discriminator field when merging Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when combining two schema's using allOf, the discriminator would not carry over to the resulting merged schema.