fix(extensions): use the x-order from next to $ref, if present#1700
Merged
jamietanna merged 4 commits intooapi-codegen:mainfrom Jul 24, 2024
Merged
fix(extensions): use the x-order from next to $ref, if present#1700jamietanna merged 4 commits intooapi-codegen:mainfrom
x-order from next to $ref, if present#1700jamietanna merged 4 commits intooapi-codegen:mainfrom
Conversation
|
I made a comment on the original issue that was closed #1611. Seems like we are waiting on this PR to be merged to resolve this bug. |
jamietanna
reviewed
Jul 24, 2024
jamietanna
changed the title
x-order from next to $ref if presentx-order from next to $ref if present
jamietanna
changed the title
x-order from next to $ref if presentx-order from next to $ref, if present
jamietanna
approved these changes
Jul 24, 2024
Member
jamietanna
left a comment
jamietanna
left a comment
There was a problem hiding this comment.
Thank you for this! Added in an additional case, and a couple of comments :)
This was referenced Sep 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part 2 of the fix for #1611.
The issues is that something like the below doesn't work.
First problem was the kin-openapi does not actually capture these values from the yaml/json. This fixed in getkin/kin-openapi#901, release in v0.126.0 and pulled in here in #1689
This is the second part which actually considers this value in the sort and officially fixes #1611. It first checks for "next to $ref" then if there is an
x-orderin the schema referenced.