fix(oapi-codegen): add missing newline to error when swagger spec load fails (oapi-codegen#1688)#1690
Merged
jamietanna merged 2 commits intooapi-codegen:mainfrom Jul 9, 2024
Conversation
Before: ``` $ oapi-codegen -generate types,client -package myproject spec.json >/dev/null error loading swagger spec in spec.json : map key "SomeMapKey" not found$ ``` After: ``` $ oapi-codegen -generate types,client -package myproject spec.json >/dev/null error loading swagger spec in spec.json : map key "SomeMapKey" not found $ ``` Closes oapi-codegen#1688
As a longer term fix for oapi-codegen#1688 to make sure that we always have a newline.
jamietanna
force-pushed
the
will/fix-missing-error-newline
branch
from
b780589 to
3be7e20
Compare
Member
|
Thanks! |
jamietanna
approved these changes
Jul 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
Closes #1688