Skip to content

fixed fiber middleware header issue#1639

Closed
dani3lsf wants to merge 3 commits intooapi-codegen:mainfrom
dani3lsf:issue-1621-fiber-header-template
Closed

fixed fiber middleware header issue#1639
dani3lsf wants to merge 3 commits intooapi-codegen:mainfrom
dani3lsf:issue-1621-fiber-header-template

Conversation

@dani3lsf
Copy link
Copy Markdown

@dani3lsf dani3lsf commented Jun 4, 2024 •
edited by jamietanna
Loading

Fix for issue: #1621

@jamietanna jamietanna added this to the v2.4.0 milestone Jul 3, 2024
@jamietanna jamietanna added bug Something isn't working server:fiber labels Jul 3, 2024
@jamietanna jamietanna modified the milestones: v2.4.0, v2.5.0 Sep 20, 2024
@dani3lsf dani3lsf requested a review from a team as a code owner November 4, 2024 14:34
alexandear
alexandear reviewed Feb 5, 2025
View reviewed changes
examples/authenticated-api/stdhttp/go.mod
module github.com/oapi-codegen/oapi-codegen/v2/examples/authenticated-api/stdhttp

go 1.22
go 1.22.8
Copy link
Copy Markdown
Contributor

@alexandear alexandear Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we need to modify go.mod files in this PR.

internal/test/go.mod
github.com/gin-gonic/gin v1.9.1
github.com/go-chi/chi/v5 v5.0.10
github.com/gofiber/fiber/v2 v2.49.1
github.com/gofiber/fiber/v2 v2.52.4
Copy link
Copy Markdown
Contributor

@alexandear alexandear Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates are handled by @dependabot, no need to manually bumping version. See #1675

@oliveromahony
Copy link
Copy Markdown

oliveromahony commented Apr 4, 2025

@dani3lsf @alexandear is there any updates on this? It is impacting fiber generation for my headers

@jamietanna jamietanna modified the milestones: v2.5.0, v2.6.0 May 11, 2025
dorzepowski
dorzepowski approved these changes May 12, 2025
View reviewed changes
Copy link
Copy Markdown

@dorzepowski dorzepowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️ Works for me

@alexandear
Copy link
Copy Markdown
Contributor

alexandear commented May 12, 2025

@dani3lsf @alexandear is there any updates on this? It is impacting fiber generation for my headers

This PR requires a review from maintainers.

@seth2810
Copy link
Copy Markdown

seth2810 commented May 23, 2025 •
edited
Loading

Hey @dani3lsf @alexandear,
The fix could be even simpler, because as it stated in fiber@v2 docs ctx.Get returns single header and it's string not slice type:

Get - Returns the HTTP request header specified by the field.

@seth2810 seth2810 mentioned this pull request May 23, 2025
Closed
@mromaszewicz
Copy link
Copy Markdown
Member

mromaszewicz commented Feb 10, 2026

Thank you for sending this PR, however I merged an earlier one (#1419) which also fixes this issue, and it supersedes this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@alexandear alexandear alexandear left review comments

@dorzepowski dorzepowski dorzepowski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working server:fiber

Projects

None yet

Milestone

v2.7.0

Development

Successfully merging this pull request may close these issues.

7 participants

@dani3lsf @oliveromahony @alexandear @seth2810 @mromaszewicz @dorzepowski @jamietanna