fix: #1530 use discriminator with several mappings for one schema#1534
Closed
jKiler wants to merge 1 commit into
Closed
fix: #1530 use discriminator with several mappings for one schema#1534jKiler wants to merge 1 commit into
jKiler wants to merge 1 commit into
Conversation
Comment on lines
+85
to
+86
| v.Breed = "maine_coon" | ||
| v.Breed = "ragdoll" |
Contributor
There was a problem hiding this comment.
This PR goes a long way to fixing the issue for me, but it doesn't address this part of the codegen
Edit: I'm looking through how union.tmpl works to see if there is an (easy) way to determine if the type of v has the discriminator field within it. I think I may have found a solution.
Contributor
There was a problem hiding this comment.
I've submitted an enhanced version of this PR -- #1789 -- which I think should address this issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've decided I'll give it a try but as long as fixing
ValueByDiscriminatorseems pretty straightforward, it requires some more changes to support proper generation ofFromXandMergeXmethods.Let's assume our
Doghas breeds[ beagle, poodle ]. It will produce a code:which seems fair if you're not planning to use it, but it compiles only if we specify our
breedasrequired.I am not fully aware of the intentions behind setting the mapping field in these methods, so I'm not sure if resigning from setting the field is the solution here.
Another pair of 👀 would be much appreciated. Cheers!