Skip to content

Remove checks for unexpected reference depth#1392

Closed
jamietanna wants to merge 5 commits intomainfrom
feature/remove-reference-depth-check
Closed

Remove checks for unexpected reference depth#1392
jamietanna wants to merge 5 commits intomainfrom
feature/remove-reference-depth-check

Conversation

@jamietanna
Copy link
Copy Markdown
Member

  • Remove checks for unexpected reference depth
  • Add test case for reference depth checks

Closes #1348.

In my opinion, this check doesn't seem to be providing much value, and
we've got a few folks requesting this be disabled.

Instead of gating this behind a feature flag, we'll just remove it.

Closes #1348.
@jamietanna jamietanna marked this pull request as draft December 18, 2023 17:04
@jamietanna
Copy link
Copy Markdown
Member Author

Requires we actually inspect what's at that path and reference that

@ghost
Copy link
Copy Markdown

ghost commented Jul 30, 2024

@jamietanna Any news on this? I'm still encountering the error in question.

@jamietanna
Copy link
Copy Markdown
Member Author

jamietanna commented Jul 30, 2024

@jhawrefvem please can you raise an issue (https://github.com/oapi-codegen/oapi-codegen/blob/main/CONTRIBUTING.md#raising-a-bug) for this?

This may now be closed by #1689 and some follow up changes

@moemoequte
Copy link
Copy Markdown

When to merge this to main branch?

@jamietanna
Copy link
Copy Markdown
Member Author

If you're still seeing issues with this, please raise an issue, as this may not be an issue any more due to other changes we've made over time @moemoequte

@moemoequte
Copy link
Copy Markdown

@jamietanna I put the problem I met in this pull request #1950

@mromaszewicz
Copy link
Copy Markdown
Member

Thank you for contributing, and I'm very sorry for taking so long to get to this PR. At this point, the code has changed so much that it's no longer relevant because reference depth handling has evolved significantly and this has likely been superseded by PR #1689 and related work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected reference depth

3 participants