Skip to content

Add test code for #695#1391

Closed
jamietanna wants to merge 2 commits intomainfrom
bug/695
Closed

Add test code for #695#1391
jamietanna wants to merge 2 commits intomainfrom
bug/695

Conversation

@jamietanna
Copy link
Copy Markdown
Member

As part of #695.

@jamietanna
Copy link
Copy Markdown
Member Author

jamietanna commented Dec 18, 2023

Not fixed by #1389 or #1387 Seems to work as-is?

As raised as part of #695,
Comment on lines +26 to +57
### Working Internal Ref to ObjectB ####
# paths:
# /api/test:
# post:
# operationId: TestApi
# summary: test
# description: test
# responses:
# '200':
# description: ''
# content:
# text/plain:
# schema:
# type: string
# '400':
# description: ''
# $ref: '#/components/responses/ResponseC'
# components:
# schemas:
# ObjectB:
# type: object
# properties:
# name:
# type: string
# responses:
# ResponseC:
# description: ResponseC
# content:
# application/json:
# schema:
# $ref: '#/components/schemas/ObjectB'

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be unnecessary?

@jamietanna jamietanna added the area:external-refs Anything related to external references (referencing other file(s) within a spec) label Jan 19, 2024
@mromaszewicz
Copy link
Copy Markdown
Member

Thank you for contributing, and I'm very sorry for taking so long to get to this PR. At this point, the code has changed so much that it's no longer relevant because external reference handling was comprehensively fixed in commit ad5eada, which likely supersedes this test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:external-refs Anything related to external references (referencing other file(s) within a spec)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants