Skip to content

Support media type parameters for IsMediaTypeJson #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamietanna merged 1 commit into from
Dec 13, 2023
Merged

Support media type parameters for IsMediaTypeJson #1386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions pkg/util/isjson.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,14 @@
package util

import "strings"
import (
"mime"
"strings"
)

func IsMediaTypeJson(mediaType string) bool {
return mediaType == "application/json" || strings.HasSuffix(mediaType, "+json")
parsed, _, err := mime.ParseMediaType(mediaType)
if err != nil {
return false
}
return parsed == "application/json" || strings.HasSuffix(parsed, "+json")
}
12 changes: 12 additions & 0 deletions pkg/util/isjson_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,18 @@ func TestIsMediaTypeJson(t *testing.T) {
mediaType: "application/vnd.api+json",
want: true,
},
{
// NOTE that this _technically_ isn't a standard extension to JSON https://www.iana.org/assignments/media-types/application/json but due to the fact that several APIs do use it, we should support it
name: "When MediaType is application/json;v=1, returns true",
mediaType: "application/json;v=1",
want: true,
},
{
// NOTE that this _technically_ isn't a standard extension to JSON https://www.iana.org/assignments/media-types/application/json but due to the fact that several APIs do use it, we should support it
name: "When MediaType is application/json;version=1, returns true",
mediaType: "application/json;version=1",
want: true,
},
}
for _, test := range suite {
t.Run(test.name, func(t *testing.T) {
Expand Down