Skip to content

Fix/strict server additional properties#1253

Closed
ShouheiNishi wants to merge 6 commits intooapi-codegen:mainfrom
ShouheiNishi:fix/strict-server-additionalProperties
Closed

Fix/strict server additional properties#1253
ShouheiNishi wants to merge 6 commits intooapi-codegen:mainfrom
ShouheiNishi:fix/strict-server-additionalProperties

Conversation

@ShouheiNishi
Copy link
Copy Markdown
Contributor

Add code to convert objects containing additionalProperties in strict server to the original type before encoding to correctly JSON-encode them.

This PR is fix for #1250
And this PR requires #1203, otherwise some test codes are broken by reference error.

@ShouheiNishi ShouheiNishi force-pushed the fix/strict-server-additionalProperties branch from 10c6bcc to 3eee779 Compare September 13, 2023 02:01
@ShouheiNishi ShouheiNishi force-pushed the fix/strict-server-additionalProperties branch from 3eee779 to bbf8299 Compare December 20, 2023 02:40
@mromaszewicz
Copy link
Copy Markdown
Member

Thank you for contributing, and I'm very sorry for taking so long to get to this PR. At this point, the code has changed so much that it's no longer relevant because AdditionalProperties handling was improved via commit 9aa9d5c ("Allow merging of schemas with additionalProperties"). The codegen now has robust support for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants