Improve logic for x-omitempty#1033
Merged
deepmap-marcinr merged 1 commit intooapi-codegen:masterfrom May 5, 2023
Merged
Conversation
Currently x-omitempty only enables you to force the _absences_ of `omitempty`. This PR changes the logic so that the existance of `x-omitempty` will force omit empty to be whatever the user specifies. The logic around omit empty is pretty confusing here though. For example, why is omitEmpty excluded by default if it's nullable (e.g. if `p.Nullable` then `omitEmpty = false`).
|
I agree with the better logic to allow explicitly setting
Because if the |
Contributor
|
Thank you. |
adrianpk
pushed a commit
to foorester/oapi-codegen
that referenced
this pull request
Jan 16, 2024
Currently x-omitempty only enables you to force the _absences_ of `omitempty`. This PR changes the logic so that the existance of `x-omitempty` will force omit empty to be whatever the user specifies. The logic around omit empty is pretty confusing here though. For example, why is omitEmpty excluded by default if it's nullable (e.g. if `p.Nullable` then `omitEmpty = false`).
adrianpk
added a commit
to foorester/oapi-codegen
that referenced
this pull request
May 31, 2024
Currently x-omitempty only enables you to force the _absences_ of `omitempty`. This PR changes the logic so that the existance of `x-omitempty` will force omit empty to be whatever the user specifies. The logic around omit empty is pretty confusing here though. For example, why is omitEmpty excluded by default if it's nullable (e.g. if `p.Nullable` then `omitEmpty = false`).
danicc097
pushed a commit
to danicc097/oapi-codegen
that referenced
this pull request
Aug 31, 2024
Currently x-omitempty only enables you to force the _absences_ of `omitempty`. This PR changes the logic so that the existance of `x-omitempty` will force omit empty to be whatever the user specifies. The logic around omit empty is pretty confusing here though. For example, why is omitEmpty excluded by default if it's nullable (e.g. if `p.Nullable` then `omitEmpty = false`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently x-omitempty only enables you to force the absence of
omitempty. This PR changes the logic so that the existance ofx-omitemptywill force omit empty to be whatever the user specifies.The logic around omit empty is pretty confusing here though. For example, why is omitEmpty excluded by default if it's nullable (e.g. if
p.NullablethenomitEmpty = false).