Duplicate typename error when generating for Jira Cloud API #1878

Activity

1. paulmach commented on Jan 9, 2025

   

   paulmach

   on Jan 9, 2025

   Contributor

   More actions

   This is due to a couple of issues in the schema:

   components:
      schemas:
        "ApprovalConfiguration": {
            "properties": {
                ....
                "exclude": {
                    "enum": [ <-- enum for an array type?
                        "assignee",
                        "reporter"
                     ],
                     "items": {
                         "enum": [
                             "assignee",
                             "reporter"
                         ],
                         "nullable": true,
                         "type": "string"
                     },
                     "nullable": true,
                     "type": "array"
                },
   

   I left out some bits but the first enum creates the ApprovalConfigurationExclude type. Then the second enum creates another enum type with the same name. This I believe is fixable by ignoring enums for array types, or auto assigning it to the items.

   The second issues is more complicated.

   components:
      schemas:
          "ProjectFeature": {
              "properties": {
                  ....
                  "state": {
                      "enum": [
                          "ENABLED",
                          "DISABLED",
                           "COMING_SOON"
                      ],
                  "type": "string"
              },
   

   and

   components:
      schemas:
         "ProjectFeatureState": {
              "additionalProperties": false,
              "description": "Details of the feature state.",
               "properties": {
                   "state": {
                       "description": "The feature state.",
                       "enum": [
                           "ENABLED",
                           "DISABLED",
                           "COMING_SOON"
                       ],
                       "type": "string"
                   }
               },
               "type": "object"
          },
   

   These will generate the same ProjectFeatureStateState enum. Might need to deduplicate or rename somehow.

   Not exactly sure of the fixes, but those are the causes.
3. paulmach commented on Jan 11, 2025

   

   paulmach

   on Jan 11, 2025

   Contributor

   More actions

   Other generators append a number, so one would be ProjectFeatureStateState and the other ProjectFeatureStateState0. I think this is the enhancement that oapi-codegen needs. I tried adding this but ran into issues.

   As for getting it to work for you right now, you can try using an OpenAPI Overlay https://github.com/oapi-codegen/oapi-codegen?tab=readme-ov-file#modifying-the-input-openapi-specification I've never used it but you could use it to add the x-go-name extensions.

   👍React with 👍1Reacted by Jamie Tanna