Moving all middleware into a single Git repo #2284
mromaszewicz
started this conversation in
Ideas
Replies: 1 comment
-
|
My 2 key concerns with this approach are:
Otherwise, this sounds good! If we can make this work, this would probably be my preference, and would make it easier to keep things consistent Other notes:
|
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I'd like to move all middleware into a single git repo, with one Go module per router type.
It would look like
The code between these is highly duplicated, and I'd like to share common code, like integration with openapi3-filter, and I'd also like them all to be at parity with each other in terms of behavior.
I think the common code could go into a peer directory that's its own module (or it could be the parent directory, not sure which is better). I don't like nested modules too much, but it's necessary to have each router middleware in its own module to avoid leaking dependencies.
What do you think, @jamietanna
Beta Was this translation helpful? Give feedback.
All reactions