feat: expose diagnostic.code in from_json & from_regex#244
feat: expose diagnostic.code in from_json & from_regex#244xiaoshihou514 merged 2 commits intonvimdev:mainfrom
Conversation
|
I think this is not backwards compatible, best to keep the defaults. |
|
Sorry, yesterday I had to go and forgot to mention that I didn't fix the tests yet. It is not backwards compatible in the sense that now the message won't include the error code by default, as seen in the failing test: Configuration doesn't (shouldn't) need to be changed and the code can be readded by using |
|
Good point. |
|
I fixed the tests, but it's my first time using busted and idk if I did something wrong or the tests don't test what I would expect. The tests in Didn't add any example of customization, idk if that's needed or not. In any case it's outside of the plugin's scope, it's just the neovim api. |
|
ok |
Expose diagnostic.code in
from_jsonandfrom_regexfor better customizabilitycloses #243