Closed
Conversation
Collaborator
|
Thanks but this has the issues outlined in #19 |
Author
|
I see, thanks for taking your time to informing me of where this has been discussed before. I rashly assumed that this issue was only discussed in issue #17 as it is still open. Is there a reason that issue is still open? From what I see, the README mentions the fix for this(although not as clearly as I would liked it to be). |
Collaborator
Not really, I think it can be closed.
If you have a concrete suggestion to clarify it a PR for that is welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request aims to solve issue #17 without the need of using the --lua-version=5.1 argument for local testing.