This repository was archived by the owner on Nov 30, 2025. It is now read-only.
fix: use fallback directory when root markers are missing#62
Merged
s1n7ax merged 1 commit intonvim-java:mainfrom Apr 16, 2024
Merged
fix: use fallback directory when root markers are missing#62s1n7ax merged 1 commit intonvim-java:mainfrom
s1n7ax merged 1 commit intonvim-java:mainfrom
Conversation
atm1020
changed the title
atm1020
force-pushed
the
fix-nil-root-dir
branch
from
4679a6d to
6418303
Compare
atm1020
force-pushed
the
fix-nil-root-dir
branch
from
1cfb595 to
de5d511
Compare
3 tasks
Member
|
I will look into this |
s1n7ax
approved these changes
Apr 16, 2024
Member
|
@atm1020 Awesome. My home dir is a git repo. That's why it worked for me all this time. This fix is working. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case the root markers are missing, use a fallback directory returned by the
vim.fn.getcwd()function. After creating any root markers, jdtls recognizes and uses them after a restart.I think people who just want to try nvim-java with a simple project, are stuck without a fallback directory.