Skip to content

chore: code clean up related to runner#208

Merged
s1n7ax merged 3 commits intomainfrom
207-feature-runner-code-refactoring
Jun 25, 2024
Merged

chore: code clean up related to runner#208
s1n7ax merged 3 commits intomainfrom
207-feature-runner-code-refactoring

Conversation

@s1n7ax
Copy link
Copy Markdown
Member

@s1n7ax s1n7ax commented Jun 9, 2024

No description provided.

@s1n7ax s1n7ax linked an issue Jun 9, 2024 that may be closed by this pull request
1 task
@s1n7ax s1n7ax requested a review from atm1020 June 9, 2024 18:42
@s1n7ax
Copy link
Copy Markdown
Member Author

s1n7ax commented Jun 9, 2024

@atm1020 I might remove the tests. Seems like they are getting in the way that preventing bugs. You can review the code and let me know what you think. I separated the code a little bit instead of having a large API module

@atm1020
Copy link
Copy Markdown
Contributor

atm1020 commented Jun 9, 2024

@s1n7ax Due to the refactoring I believe some spy/mock are not being used, which is why the tests are hanging. Therefore, I think runner_spec.lua should also be separated into different files and the tests needs to be rewritten too, but this new structure will makes the tests less complex too.

@s1n7ax
Copy link
Copy Markdown
Member Author

s1n7ax commented Jun 25, 2024

@atm1020 I'm removing failing tests. I think project is small enough to ignore tests.

@s1n7ax s1n7ax merged commit fd5aad9 into main Jun 25, 2024
@s1n7ax s1n7ax deleted the 207-feature-runner-code-refactoring branch June 25, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: Runner code refactoring

2 participants