Skip to content

fix: profile deletion does not work#158

Merged
s1n7ax merged 3 commits intomainfrom
157-bug-javaprofile-profile-deletion-does-not-work
Apr 12, 2024
Merged

fix: profile deletion does not work#158
s1n7ax merged 3 commits intomainfrom
157-bug-javaprofile-profile-deletion-does-not-work

Conversation

@s1n7ax
Copy link
Copy Markdown
Member

@s1n7ax s1n7ax commented Apr 12, 2024

No description provided.

@s1n7ax s1n7ax requested a review from atm1020 April 12, 2024 08:08
@s1n7ax s1n7ax linked an issue Apr 12, 2024 that may be closed by this pull request
3 tasks
submit = { '<CR>', '<Space>' },
},
on_change = function(item)
self.focus_item = item
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On change callback is not being called on cursor change so the focus_item is the top most node when the window is opened. As a result deletion fails because focus_item is always the active item

@s1n7ax s1n7ax merged commit cb62d07 into main Apr 12, 2024
@s1n7ax s1n7ax deleted the 157-bug-javaprofile-profile-deletion-does-not-work branch April 12, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: JavaProfile profile deletion does not work

1 participant