Skip to content

Remove Runner clear_env - #150

Merged
s1n7ax merged 1 commit into
nvim-java:mainfrom
OmniSudo:main
Mar 30, 2024
Merged

s1n7ax merged 1 commit into
nvim-java:mainfrom
OmniSudo:main

Conversation

@OmniSudo

Copy link
Copy Markdown
Contributor

This allows for stuff like AWT to access the DISPLAY environment variable.

@s1n7ax

s1n7ax commented Mar 28, 2024

Copy link
Copy Markdown
Member

@atm1020 What do you think? Any particular reason to clear env?

@OmniSudo Could you confirm the default behavior of intelij or eclipse?

@OmniSudo

Copy link
Copy Markdown
Contributor Author

With intellij, I can run my awt app and it copies environment variables that exist from pre run (namely DISPLAY=:0 for X11 run an awt app without it being headless)

@atm1020

atm1020 commented Mar 28, 2024

Copy link
Copy Markdown
Contributor

@s1n7ax There is no specific reason for it. I just didnt consider use cases like this, so I think its gonna be okey

@s1n7ax
s1n7ax merged commit 9860a93 into nvim-java:main Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants