Skip to content

feat: APIs to run application#136

Merged
s1n7ax merged 8 commits intonvim-java:mainfrom
s1n7ax:feature-api-to-run-application
Mar 17, 2024
Merged

feat: APIs to run application#136
s1n7ax merged 8 commits intonvim-java:mainfrom
s1n7ax:feature-api-to-run-application

Conversation

@s1n7ax
Copy link
Copy Markdown
Member

@s1n7ax s1n7ax commented Mar 17, 2024

No description provided.

@s1n7ax
Copy link
Copy Markdown
Member Author

s1n7ax commented Mar 17, 2024

@atm1020 Hi, after multiple attmpts to fix tests, I decided to comment them out. For some reason they hang at following mock statement. Note sure why. May be you can check that since you have more experience in testing neovim stuff.

local vim = mock(vim, true)

@s1n7ax s1n7ax merged commit a0c6c1b into nvim-java:main Mar 17, 2024
@s1n7ax
Copy link
Copy Markdown
Member Author

s1n7ax commented Mar 17, 2024

@atm1020 Sorry, It took way longer than it should. I will make sure future PRs are merge as soon as possible.

@atm1020
Copy link
Copy Markdown
Contributor

atm1020 commented Mar 18, 2024

@s1n7ax Hi, no problem! Im going to check the broken tests!

@atm1020
Copy link
Copy Markdown
Contributor

atm1020 commented Mar 18, 2024

@s1n7ax Should I open an issue for this, or is it okay to just open a PR without a corresponding issue?

@s1n7ax s1n7ax deleted the feature-api-to-run-application branch March 18, 2024 12:58
@s1n7ax
Copy link
Copy Markdown
Member Author

s1n7ax commented Mar 18, 2024

@atm1020 A new issue and PR would be good

@atm1020
Copy link
Copy Markdown
Contributor

atm1020 commented Mar 18, 2024

@s1n7ax I created a PR: #140 with ticket: #139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants