Link to issue number:

Fixes #19395
Fix-up of #19173.

Summary of the issue:

Sometimes, e.g. in Notepad, skim reading process was not correctly interrupted when pressing control key: say all was restarting when another key was pressed.

Description of user facing changes:

Skim reading process is now correctly interrupted when control is pressed.

Description of developer facing changes:

N/A

Description of development approach:

When the speech sequence is stored, it is first filtered.
CallbackCommands are filtered out of the sequence since callback functions such as say all ones should not be called again when repeating the last speech (this was the cause of say all restarting).

Not all BaseCallbackCommands are filtered since other BaseCallbackCommand such as BeepCommand (for indentation reporting) or WaveFileCommands (for spelling error reporting) still need to be reported.

I have not included IndexCommands in the filtering since in any case, they only seem to appear downstream, in the speech manager part.

Regarding CancellableSpeechCommands, I have included them, since I've seen that they are also filtered out from remote speech. Though, I do not exactly know how cancellable speech works, so please double check. Thanks.

Testing strategy:

Manual test of speech repetition in browse mode as well as in Notepad and tests with skim reading as described in #19395.
Also tested that indentation beeps or spelling errors sounds while reading are still played when repeating the last speech.

Known issues with pull request:

None

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.