fix(nitro): ensure html is a string before injecting error handler

danielroe · danielroe · commit 6f51a25e9f65 · 2025-12-09T15:41:02.000Z
resolves #33748
diff --git a/packages/nitro-server/src/runtime/handlers/error.ts b/packages/nitro-server/src/runtime/handlers/error.ts
@@ -84,7 +84,7 @@ export default <NitroErrorHandler> async function errorhandler (error, event, {
   }
   setResponseStatus(event, res.status && res.status !== 200 ? res.status : defaultRes.status, res.statusText || defaultRes.statusText)
 
-  if (import.meta.dev && !import.meta.test) {
+  if (import.meta.dev && !import.meta.test && typeof html === 'string') {
     const prettyResponse = await defaultHandler(error, event, { json: false })
     return send(event, html.replace('</body>', `${generateErrorOverlayHTML(prettyResponse.body as string, { startMinimized: 300 <= statusCode && statusCode < 500 })}</body>`))
   }

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ export default <NitroErrorHandler> async function errorhandler (error, event, {`
`84`	`84`	`}`
`85`	`85`	`setResponseStatus(event, res.status && res.status !== 200 ? res.status : defaultRes.status, res.statusText \|\| defaultRes.statusText)`
`86`	`86`
`87`		`- if (import.meta.dev && !import.meta.test) {`
	`87`	`+ if (import.meta.dev && !import.meta.test && typeof html === 'string') {`
`88`	`88`	`const prettyResponse = await defaultHandler(error, event, { json: false })`
`89`	`89`	return send(event, html.replace('</body>', `${generateErrorOverlayHTML(prettyResponse.body as string, { startMinimized: 300 <= statusCode && statusCode < 500 })}</body>`))
`90`	`90`	`}`