Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
random float 1..<1andrandom float (-1e308)..1e308currently panic in rand. Use fallible sampling-range constructors and return the existingInvalidRangeerror when a range cannot be sampled. Preserve descending-range validation and valid inclusive, exclusive and unbounded rangesAdds regressions for empty ranges, overflowing range widths and negative values.
User-facing changes (Release notes)
random floatreports an error for empty or unrepresentable sampling ranges instead of panickingAdditional notes
The actual
randomtest sources pass through a local builtin Rust harness (21 tests). The prescribed custom harness discovers zero tests on this Windows GNU setup, so that invocation is not counted as validation.cargo nuclippy, workspace formatting and typos pass. Full workspace tests and hosted CI have not been run1