Fix duplicate PWD error messages when directory is deleted#17355
Open
po-nuvai wants to merge 1 commit intonushell:mainfrom
Open
Fix duplicate PWD error messages when directory is deleted#17355po-nuvai wants to merge 1 commit intonushell:mainfrom
po-nuvai wants to merge 1 commit intonushell:mainfrom
Conversation
When running commands from a deleted directory, the error message "$env.PWD points to a non-existent directory" was printed 4-5 times because multiple operations in the REPL loop independently check cwd. This fix adds a `cwd_error_reported_this_cycle` flag to EngineState that tracks whether a cwd error has already been reported in the current REPL iteration. The flag is reset at the start of each iteration and checked before reporting subsequent cwd errors. Closes nushell#17284
Contributor
|
Thanks for the PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cwd_error_reported_this_cycleflag to track when a cwd error has been reported in the current REPL iterationTest plan
mkdir /tmp/test_dir && cd /tmp/test_dirrm -rf /tmp/test_dirlsCloses #17284