Attempt to warn about cpanm fails to install

nunorc · nunorc · commit fb6af8c003f8 · 2015-12-22T12:17:41.000Z
diff --git a/Changes b/Changes
@@ -2,6 +2,7 @@
 {{$NEXT}}
 
     * Create p5stack directory if missing (Issue#2, reported by AMBS++).
+    * Attempt to warn about cpanm misses (Issue#3, reported by AMBS++).
 
 0.003     2015-11-19 22:29:12+00:00 Europe/Lisbon
 
diff --git a/lib/App/p5stack.pm b/lib/App/p5stack.pm
@@ -104,6 +104,7 @@ sub _do_setup {
   $self->_do_install_perl_release;
 
   system "curl -s -L https://cpanmin.us | $self->{perl} - -l $self->{local_lib} --reinstall --no-sudo App::cpanminus local::lib > $self->{log_file} 2>&1";
+  $self->{cpanm_flag} = $? >> 8;
 
   _log("Getting dependencies info using '$self->{deps}' ...");
   _log('Installing dependencies ...');
@@ -118,6 +119,7 @@ sub _do_setup {
       exit;
     }
     system "$dzil listdeps | $cpanm --no-sudo -l $self->{local_lib}";
+    $self->{cpanm_flag} = $? >> 8;
   }
   if ($self->{deps} eq 'cpanfile') {
     unless (-e catfile($self->{home},'cpanfile')) {
@@ -127,6 +129,9 @@ sub _do_setup {
     $self->_do_cpanm("--installdeps .");
   }
 
+  if ($self->{cpanm_flag}) {
+    print "[p5stack] Warning, cpanm may have failed to install something!\n";
+  }
   print "[p5stack] Setup done, use 'p5stack perl' to run your application.\n";
 }
 
@@ -198,6 +203,7 @@ sub _do_cpanm {
   my $run = join ' ', $cpanm, "--no-sudo", "-L $self->{local_lib}", @args, $log;
 
   system $run;
+  $self->{cpanm_flag} = $? >> 8;
 }
 
 sub _do_bin {

Original file line number	Diff line number	Diff line change
`@@ -104,6 +104,7 @@ sub _do_setup {`
`104`	`104`	`$self->_do_install_perl_release;`
`105`	`105`
`106`	`106`	`system "curl -s -L https://cpanmin.us \| $self->{perl} - -l $self->{local_lib} --reinstall --no-sudo App::cpanminus local::lib > $self->{log_file} 2>&1";`
	`107`	`+ $self->{cpanm_flag} = $? >> 8;`
`107`	`108`
`108`	`109`	`_log("Getting dependencies info using '$self->{deps}' ...");`
`109`	`110`	`_log('Installing dependencies ...');`
`@@ -118,6 +119,7 @@ sub _do_setup {`
`118`	`119`	`exit;`
`119`	`120`	`}`
`120`	`121`	`system "$dzil listdeps \| $cpanm --no-sudo -l $self->{local_lib}";`
	`122`	`+ $self->{cpanm_flag} = $? >> 8;`
`121`	`123`	`}`
`122`	`124`	`if ($self->{deps} eq 'cpanfile') {`
`123`	`125`	`unless (-e catfile($self->{home},'cpanfile')) {`
`@@ -127,6 +129,9 @@ sub _do_setup {`
`127`	`129`	`$self->_do_cpanm("--installdeps .");`
`128`	`130`	`}`
`129`	`131`
	`132`	`+ if ($self->{cpanm_flag}) {`
	`133`	`+ print "[p5stack] Warning, cpanm may have failed to install something!\n";`
	`134`	`+ }`
`130`	`135`	`print "[p5stack] Setup done, use 'p5stack perl' to run your application.\n";`
`131`	`136`	`}`
`132`	`137`
`@@ -198,6 +203,7 @@ sub _do_cpanm {`
`198`	`203`	`my $run = join ' ', $cpanm, "--no-sudo", "-L $self->{local_lib}", @args, $log;`
`199`	`204`
`200`	`205`	`system $run;`
	`206`	`+ $self->{cpanm_flag} = $? >> 8;`
`201`	`207`	`}`
`202`	`208`
`203`	`209`	`sub _do_bin {`