BUG: avoid possible stack overflow in arraydescr_dealloc (#32133) - #32158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #32133.
PR summary
The
Py_DECREF(lself->subarray->base)we currently have can lead to situations where the DECREF causes a deallocation, which then recursively calls intoarraydescr_dealloc. With a properly setup dtype, this can lead to a stack overflow on newer Python versions. See python/cpython#142253 for the upstream issue that was opened about that and #30370 on the NumPy side.My fix is to check for cases when decrefing will deallocate and in those cases explicitly detach the
basebefore decrefing, avoiding the recursive call.AI Disclosure
I used an AI model to understand the problem and debug the fix and new test.