BUG: reference leak in simd_sequence_from_iterable - #32038
Merged
seberg merged 1 commit intoJul 19, 2026
Conversation
PySequence_Fast returns a new reference that was released on the min-size error path but not when simd_sequence_new failed. Drop the Fast ref on allocation failure so OOM does not leak the sequence. Signed-off-by: Abhijeetsingh Meena <abhijeet040403@gmail.com>
ngoldbaum
changed the title
seq_obj on simd_sequence_from_iterable OOMsimd_sequence_from_iterable
charris
pushed a commit
that referenced
this pull request
Jul 27, 2026
Signed-off-by: Abhijeetsingh Meena <abhijeet040403@gmail.com>
charris
added a commit
that referenced
this pull request
Jul 27, 2026
BUG: reference leak in `simd_sequence_from_iterable` (#32038)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
simd_sequence_from_iterableleaked thePySequence_Fastresult whensimd_sequence_newfailed: the min-size path alreadyPy_DECREFd, the OOM path did not. Add the missingPy_DECREF.No new test; the leak only runs on allocation failure, which we cannot force from Python. Same approach as #31968 (no
getrefcountasserts).No release note (internal leak; no API change).
First time committer introduction
Exploring NumPy and submitting small correctness fixes (e.g. #31968).
AI Disclosure
AI helped locate and draft the fix. Human-reviewed and submitted by a human.