BUG: fix crash on 32 bit systems using abi3t (#31771) - #31949
Merged
Conversation
Co-authored-by: Sebastian Berg <sebastianb@nvidia.com> Co-authored-by: Nathan Goldbaum <nathan.goldbaum@gmail.com>
charris
added
08 - Backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #31771.
PR summary
Fixes #31762
This PR fixes the crash on 32 bit systems when using abi3t ABI. In this PR, the first member of the
PyArrayDescris now aligned to 8 bytes so that regardless of the size of the actualPyObject, the field accesses remain correct. 8 bytes is used instead ofalignof(max_align_t)to preserve backwards compatibility with exisiting abi3 extensions wheresizeof(PyObject)is a multiple of 8 thereby the added alignment is no-op and does not changes the offset for such extensions.AI Disclosure
AI was used to create the test.