Update x86-simd-sort subproject (5adb334 → fa944ef) - #31908
Merged
Conversation
- Add MSVC/Windows build support with DllMain-based dispatch init - Add nans_last parameter to all sort/select APIs to decouple NaN placement from sort direction - Add descending parameter to argselect; fix mirror-index bug - Propagate const T* through argsort/argselect APIs - Convert CRLF→LF; clang-format-18 pass; CI MSVC job added
MaanasArora
approved these changes
Jul 8, 2026
MaanasArora
left a comment
MaanasArora
left a comment
Contributor
There was a problem hiding this comment.
Great, thank you @r-devulap, clearly no issues here, except I'm not sure if this shouldn't be backported so we can also backport the performance fix for descending sorts? Let's check with @seberg (sorry for the ping!)
Member
|
I am fine with backporting it as well to consider it a perf bugfix, as it seems rather safe. That said, also not too worried if we don't/decide not to. |
seberg
added
03 - Maintenance
09 - Backport-Candidate
charris
added a commit
that referenced
this pull request
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Porting latest x86-simd-sort changes to NumPy: summary of relevant changes:
AI Disclosure
Copilot authored: numpy/x86-simd-sort#231