BUG: fix StringDType coerce flag in binary ufunc promotion (#31862) - #31901
Merged
Conversation
charris
added
00 - Bug
08 - Backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport or #31862.
PR summary
Fixes #31861.
Binary
StringDTypeufuncs resolved outputcoercewithdescr1->coerce && descr1->coerceinstead of combining both operands.That made results order-dependent (e.g.
np.addwithcoerce=Truethencoerce=Falsekeptcoerce=True) and allowed non-string assignment via implicit stringification.This changes the combination to
descr1->coerce && descr2->coerce, matchingcommon_instance/np.promote_types, and adds a small regression test for both operand orders.First time committer introduction
I have been using NumPy for some time now. I hit this while working with
StringDTypeandcoerce, and found two places with similar typo bug. I checked and found that one typo incommon_instancehas been fixed yesterday, so wanted to fix the remaining typo in the binary ufunc path.AI Disclosure
I used Grok to help locate the bug in
binary_resolve_descriptors, draft the regression test, and refine the issue/PR wording. I made and verified the fix with correctness checks, rebuilds and the test suite; final review and PR submission were done by me.