TST: add tests for stable ABI numpy extensions (#31822) - #31900
Merged
Conversation
Co-authored-by: da-woods <dw-git@d-woods.co.uk> Co-authored-by: Nathan Goldbaum <nathan.goldbaum@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #31822.
PR summary
This PR adds tests for stable ABI extensions compiled with numpy C-API as well as cython API.
limited_api.cis used as a template and parameterized byMODULE_NAMEfor every combination of Python abi3 version and NumPy target version. Same is done forlimited_api_cythonwhere cython extension is tested against every combination of Python abi3 version and NumPy target version. I've expanded tests to cover the datetime APIs which was broken recently to avoid such future breakages.The failing MSVC test on x86 is because of #31762 which is now detected as a failure.
AI Disclosure
I used Claude to work on this.
PR summary
This PR adds tests for stable ABI extensions compiled with numpy C-API as well as cython API.
limited_api.cis used as a template and parameterized byMODULE_NAMEfor every combination of Python abi3 version and NumPy target version. Same is done forlimited_api_cythonwhere cython extension is tested against every combination of Python abi3 version and NumPy target version. I've expanded tests to cover the datetime APIs which was broken recently to avoid such future breakages.The failing MSVC test on x86 is because of #31762 which is now detected as a failure.
AI Disclosure
I used Claude to work on this.