TYP: Backport multiple static typing fixes 1. - #31889
Merged
charris merged 11 commits intoJul 6, 2026
Merged
Conversation
|
Diff from mypy_primer, showing the effect of this PR on type check results on a corpus of open source code: jax (https://github.com/google/jax)
- jax/_src/numpy/hijax.py:269: error: Incompatible types in assignment (expression has type "tuple[Any, ...]", variable has type "ndarray[tuple[Any, ...], dtype[float64]]") [assignment]
+ jax/_src/numpy/hijax.py:269: error: Incompatible types in assignment (expression has type "tuple[Any, ...]", variable has type "ndarray[tuple[Any, ...], dtype[signedinteger[Any]]]") [assignment]
pandas-stubs (https://github.com/pandas-dev/pandas-stubs)
- tests/scalars/test_scalars.py:570: error: Unused "type: ignore" comment [unused-ignore]
- tests/scalars/test_scalars.py:618: error: Unused "type: ignore" comment [unused-ignore]
|
charris
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports of:
TYP: fix
tri{l,u}shape-typing for 1d input (#31886)TYP: fix int promotion for
linalg.trace(#31885)TYP: fix
datetime64unit conversion (#31883)TYP: fix swapped
linalg.slogdetdtypes ofsign/logabsdet(#31882)TYP: fix
random.RandomState.get_stateconflicting overloads (#31881)TYP: fix
std/varoutput type for complex input (#31880)TYP: fix
str_.__getitem__andbytes_.__getitem__(#31879)TYP: fix Pyright error for
piecewisewith all-scalarfunclist(#31878)TYP: fix
random.Generator.choiceoutput type for int sequences (#31877)TYP: fix int promotion for
*sumand*prod(#31876)TYP: fix unit-dependent
timedelta64/datetime64overloads (#31874)