MNT: remove some obsolete string to bool workarounds - #31859
Merged
Conversation
ikrommyd
changed the title
count_nonzero to a one-liner
ikrommyd
changed the title
count_nonzero to a one-linernp.character branch for array conversion to boolean dtype in count_nonzero
ikrommyd
changed the title
np.character branch for array conversion to boolean dtype in count_nonzero
Signed-off-by: Iason Krommydas <iason.krom@gmail.com>
Signed-off-by: Iason Krommydas <iason.krom@gmail.com>
ikrommyd
force-pushed
the
cleanup-count-nonzero
branch
from
July 4, 2026 06:14
cca5338 to
809e62b
Compare
Signed-off-by: Iason Krommydas <iason.krom@gmail.com>
eendebakpt
reviewed
Jul 4, 2026
| else: | ||
| a_bool = a.astype(np.bool, copy=False) | ||
|
|
||
| a_bool = a.astype(np.bool, copy=False) |
Contributor
There was a problem hiding this comment.
asanyarray has a dtype and copy argument. Can this cast be combined with the previous line?
Member
Author
There was a problem hiding this comment.
Ah yeah with copy=None which is the default in asanyarray it should theoretically be equivalent. Done.
Signed-off-by: Iason Krommydas <iason.krom@gmail.com>
ngoldbaum
reviewed
Jul 7, 2026
Member
Author
|
@ngoldbaum I think I addressed all your review comments. |
Member
|
Thanks @ikrommyd! |
charris
pushed a commit
that referenced
this pull request
Jul 10, 2026
charris
added a commit
that referenced
this pull request
Jul 10, 2026
MNT: remove some obsolete string to bool workarounds (#31859)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Removes a couple of obsolete string to bool workarounds and updates a comment and adds a tiny bit of testing.
First time committer introduction
N/A
AI Disclosure
No AI