MAINT: Use Python C API functions for f2py error formatting#31584
Open
da-woods wants to merge 2 commits into
Open
MAINT: Use Python C API functions for f2py error formatting#31584da-woods wants to merge 2 commits into
da-woods wants to merge 2 commits into
Conversation
My original interest here was to eliminate the non-limited API access to `->tp_name`. However, looking at what I was changing, it seemed like a large amount of C string handling could be removed in the process (and because the result inevitably ends up in Python strings, I don't think this is any less efficient). The main effect is to eliminate a bunch of fixed-size string buffers and the possibility for overflowing those. Hopefully most of the output should be identical. There's one place where I've updated a test because the output is slightly different and the old version really didn't make sense to me.
da-woods
changed the title
available in earlier limited API versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
My original interest here was to eliminate the non-limited API access to
->tp_name(and thus it's kind of part of #21300). However, looking at what I was changing, it seemed like a large amount of C string handling could be removed in the process (and because the result inevitably ends up in Python strings, I don't think this is any less efficient).The main effect is to eliminate a bunch of fixed-size string buffers and the possibility for overflowing those.
Hopefully most of the output should be identical. There's one place where I've updated a test because the output is slightly different and the old version really didn't make sense to me.
AI Disclosure
All code and text was written by me. I used copilot to find a silly mistake I'd made that was causing it to crash (because I couldn't get
gdbandspinto cooperate here) and to sanity check what I'd done.