BUG: Handle nan values on histogram's slow path.#31461
Open
JosephMehdiyev wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
Maybe an additional warning about the data containing nan values and how the histogram handles it would be nice addition? Otherwise it might be ambigious? |
Member
|
If we go with #31431, I think we'll get this for free so I am not sure we should go the manual route here. |
Contributor
Author
|
#31431 surely would be a better fix (didn't know that PR existed), although I tried to test that branch and the issue is still there |
Member
|
Ah, right. That changes sorting but this would (also?) need |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Fixes #28730
Contrary to histogramdd (which is another problem I think), histogram uses a different algorithm that uses
_search_sorted_inclusiveon its slow path where nan values work ambigiously depending on the dtype. This is a small workaround to fix it basically.I am still not sure if this fix is proper, I will play around the PR until its readyAI Disclosure
I have used claude to review the code. The changes are not AI written.