BUG: fix free-threaded races in RandomState - #30360
Merged
Merged
Conversation
ngoldbaum
added
39 - free-threading
ngoldbaum
force-pushed
the
randomstate-critical-sections
branch
from
December 2, 2025 22:55
03132a0 to
95e36ee
Compare
Member
Author
|
Looks like this also requires updating the minimum Cython version, so I'm going to remove the backport label... |
Member
Author
|
Well, looks like that didn't work on the TSan CI job. Likely will need a different approach. Converting to a draft PR for now. |
ngoldbaum
marked this pull request as draft
December 2, 2025 23:39
ngoldbaum
marked this pull request as ready for review
December 3, 2025 03:28
Member
Author
|
Nice! Just using the generator lock seems to work. Re-added the backport label since this doesn't require a Cython version bump using the lock. Ping @rkern too. |
Member
|
Seems sound to me. |
Member
|
Thanks @ngoldbaum |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes one of the races in #30085.
I'd appreciate it if one of @lysnikolaou, @kumaraditya303, or @crusaderky could look this over, since you're all doing work related to this change.
I verified that the test I added generates TSan races without the cython change to add critical sections.
As far as I can tell, all other reads and writes to internal state are either atomic (e.g. in
get_state) or are done with athreading.lockheld and don't need any additional synchronization.